mirror of
https://code.videolan.org/videolan/dav1d
synced 2026-06-11 04:03:05 +00:00
There are a number of benefits tied to the upstream / third-party checkasm version, including: - Improved long-term maintainability, code reuse with other projects, etc. - Vastly improved overall performance / runtime for benchmarking, due primarily to the ability to scale the runtime of each test to that test's complexity. - Much more robust statistical analysis of benchmarking results; including robust outlier rejection, an estimation of the histogram, and the ability to report the variance / stddev in addition to the (trimmed) mean. - Interactive HTML and JSON output formats in addition to CSV/TSV. - More readable and user-friendly output across the board, especially for failures and data dumps (e.g. also showing errors inside padding bytes). - Better cross-platform support, including dynamic fallback of timer implementations on ARM platforms, a better RISC-V harness, and more. There are multiple approaches to how we can solve the problem of integrating this third party checkasm into dav1d, but I think the hybrid approach of loading it as an external dependency, falling back to a meson wrap file, provides the best overall compromise. This avoids the messiness of git e.g. git submodules, while still allowing us to pin individual tags.
145 lines
6.1 KiB
C
145 lines
6.1 KiB
C
/*
|
|
* Copyright © 2018, VideoLAN and dav1d authors
|
|
* Copyright © 2018, Two Orioles, LLC
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are met:
|
|
*
|
|
* 1. Redistributions of source code must retain the above copyright notice, this
|
|
* list of conditions and the following disclaimer.
|
|
*
|
|
* 2. Redistributions in binary form must reproduce the above copyright notice,
|
|
* this list of conditions and the following disclaimer in the documentation
|
|
* and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
|
|
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
|
|
* WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
|
|
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR
|
|
* ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
|
|
* (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
|
|
* LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
|
|
* ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
|
|
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include "tests/checkasm/internal.h"
|
|
|
|
#include <string.h>
|
|
#include <stdio.h>
|
|
|
|
#include "common/dump.h"
|
|
|
|
#include "src/levels.h"
|
|
#include "src/cdef.h"
|
|
|
|
static int to_binary(int x) { /* 0-15 -> 0000-1111 */
|
|
return (x & 1) + 5 * (x & 2) + 25 * (x & 4) + 125 * (x & 8);
|
|
}
|
|
|
|
static void init_tmp(pixel *buf, int n, const int bitdepth_max) {
|
|
const int fill_type = rnd() & 7;
|
|
if (fill_type == 0)
|
|
while (n--) /* check for cdef_filter underflows */
|
|
*buf++ = rnd() & 1;
|
|
else if (fill_type == 1)
|
|
while (n--) /* check for cdef_filter overflows */
|
|
*buf++ = bitdepth_max - (rnd() & 1);
|
|
else
|
|
while (n--)
|
|
*buf++ = rnd() & bitdepth_max;
|
|
}
|
|
|
|
static void check_cdef_filter(const cdef_fn fn, const int w, const int h) {
|
|
ALIGN_STK_64(pixel, c_src, 16 * 10 + 16, ), *const c_dst = c_src + 8;
|
|
ALIGN_STK_64(pixel, a_src, 16 * 10 + 16, ), *const a_dst = a_src + 8;
|
|
ALIGN_STK_64(pixel, top_buf, 16 * 2 + 16, ), *const top = top_buf + 8;
|
|
ALIGN_STK_64(pixel, bot_buf, 16 * 2 + 16, ), *const bot = bot_buf + 8;
|
|
ALIGN_STK_16(pixel, left, 8,[2]);
|
|
const ptrdiff_t stride = 16 * sizeof(pixel);
|
|
|
|
declare_func(void, pixel *dst, ptrdiff_t dst_stride, const pixel (*left)[2],
|
|
const pixel *top, const pixel *bot, int pri_strength,
|
|
int sec_strength, int dir, int damping,
|
|
enum CdefEdgeFlags edges HIGHBD_DECL_SUFFIX);
|
|
|
|
for (int s = 0x1; s <= 0x3; s++) {
|
|
if (check_func(fn, "cdef_filter_%dx%d_%02d_%dbpc", w, h, to_binary(s), BITDEPTH)) {
|
|
for (int dir = 0; dir < 8; dir++) {
|
|
for (enum CdefEdgeFlags edges = 0x0; edges <= 0xf; edges++) {
|
|
#if BITDEPTH == 16
|
|
const int bitdepth_max = rnd() & 1 ? 0x3ff : 0xfff;
|
|
#else
|
|
const int bitdepth_max = 0xff;
|
|
#endif
|
|
const int bitdepth_min_8 = bitdepth_from_max(bitdepth_max) - 8;
|
|
|
|
init_tmp(c_src, 16 * 10 + 16, bitdepth_max);
|
|
init_tmp(top_buf, 16 * 2 + 16, bitdepth_max);
|
|
init_tmp(bot_buf, 16 * 2 + 16, bitdepth_max);
|
|
init_tmp((pixel *) left, 8 * 2, bitdepth_max);
|
|
memcpy(a_src, c_src, (16 * 10 + 16) * sizeof(pixel));
|
|
|
|
const int pri_strength = s & 2 ? (1 + (rnd() % 15)) << bitdepth_min_8 : 0;
|
|
const int sec_strength = s & 1 ? 1 << ((rnd() % 3) + bitdepth_min_8) : 0;
|
|
const int damping = 3 + (rnd() & 3) + bitdepth_min_8 - (w == 4 || (rnd() & 1));
|
|
call_ref(c_dst, stride, left, top, bot, pri_strength, sec_strength,
|
|
dir, damping, edges HIGHBD_TAIL_SUFFIX);
|
|
call_new(a_dst, stride, left, top, bot, pri_strength, sec_strength,
|
|
dir, damping, edges HIGHBD_TAIL_SUFFIX);
|
|
if (checkasm_check_pixel(c_dst, stride, a_dst, stride, w, h, "dst")) {
|
|
fprintf(stderr, "strength = %d:%d, dir = %d, damping = %d, edges = %04d\n",
|
|
pri_strength, sec_strength, dir, damping, to_binary(edges));
|
|
return;
|
|
}
|
|
if (dir == 7 && (edges == 0x5 || edges == 0xa || edges == 0xf))
|
|
bench_new(alternate(c_dst, a_dst), stride, left, top, bot, pri_strength,
|
|
sec_strength, dir, damping, edges HIGHBD_TAIL_SUFFIX);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
static void check_cdef_direction(const cdef_dir_fn fn) {
|
|
ALIGN_STK_64(pixel, src, 8 * 8,);
|
|
|
|
declare_func(int, const pixel *src, ptrdiff_t dst_stride, unsigned *var
|
|
HIGHBD_DECL_SUFFIX);
|
|
|
|
if (check_func(fn, "cdef_dir_%dbpc", BITDEPTH)) {
|
|
unsigned c_var, a_var;
|
|
#if BITDEPTH == 16
|
|
const int bitdepth_max = rnd() & 1 ? 0x3ff : 0xfff;
|
|
#else
|
|
const int bitdepth_max = 0xff;
|
|
#endif
|
|
init_tmp(src, 64, bitdepth_max);
|
|
|
|
const int c_dir = call_ref(src, 8 * sizeof(pixel), &c_var HIGHBD_TAIL_SUFFIX);
|
|
const int a_dir = call_new(src, 8 * sizeof(pixel), &a_var HIGHBD_TAIL_SUFFIX);
|
|
if (c_var != a_var || c_dir != a_dir) {
|
|
if (fail()) {
|
|
hex_fdump(stderr, src, 8 * sizeof(pixel), 8, 8, "src");
|
|
fprintf(stderr, "c_dir %d a_dir %d\n", c_dir, a_dir);
|
|
}
|
|
}
|
|
bench_new(src, 8 * sizeof(pixel), &a_var HIGHBD_TAIL_SUFFIX);
|
|
}
|
|
report("cdef_dir");
|
|
}
|
|
|
|
void bitfn(checkasm_check_cdef)(void) {
|
|
Dav1dCdefDSPContext c;
|
|
bitfn(dav1d_cdef_dsp_init)(&c);
|
|
|
|
check_cdef_direction(c.dir);
|
|
|
|
check_cdef_filter(c.fb[0], 8, 8);
|
|
check_cdef_filter(c.fb[1], 4, 8);
|
|
check_cdef_filter(c.fb[2], 4, 4);
|
|
report("cdef_filter");
|
|
}
|