mirror of
https://github.com/go-gitea/gitea
synced 2026-07-17 05:36:09 +00:00
wxiaoguangandGitHub
82edc3da01
1. Storing "ctx" in a long-living object is wrong 2. Make the commit & tree cacheable (for the future performance optimization) 3. Also fix some bad designs like `// FIXME: bad design, this field can be nil if the commit is from "last commit cache"` ref: * #33893
55 lines
1.6 KiB
Go
55 lines
1.6 KiB
Go
// Copyright 2024 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package git
|
|
|
|
import "context"
|
|
|
|
type SubmoduleWebLink struct {
|
|
RepoWebLink, CommitWebLink string
|
|
}
|
|
|
|
// GetSubModules get all the submodules of current revision git tree
|
|
func (c *Commit) GetSubModules(ctx context.Context, gitRepo *Repository) (*ObjectCache[*SubModule], error) {
|
|
if c.submoduleCache != nil {
|
|
return c.submoduleCache, nil
|
|
}
|
|
|
|
entry, err := c.GetTreeEntryByPath(ctx, gitRepo, ".gitmodules")
|
|
if err != nil {
|
|
if _, ok := err.(ErrNotExist); ok {
|
|
return nil, nil //nolint:nilnil // return nil to indicate that the submodule does not exist
|
|
}
|
|
return nil, err
|
|
}
|
|
|
|
rd, err := entry.Blob(gitRepo).DataAsync()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
defer rd.Close()
|
|
|
|
// at the moment we do not strictly limit the size of the .gitmodules file because some users would have huge .gitmodules files (>1MB)
|
|
c.submoduleCache, err = configParseSubModules(rd)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return c.submoduleCache, nil
|
|
}
|
|
|
|
// GetSubModule gets the submodule by the entry name.
|
|
// It returns "nil, nil" if the submodule does not exist, caller should always remember to check the "nil"
|
|
func (c *Commit) GetSubModule(ctx context.Context, gitRepo *Repository, entryName string) (*SubModule, error) {
|
|
modules, err := c.GetSubModules(ctx, gitRepo)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if modules != nil {
|
|
if module, has := modules.Get(entryName); has {
|
|
return module, nil
|
|
}
|
|
}
|
|
return nil, nil //nolint:nilnil // return nil to indicate that the submodule does not exist
|
|
}
|