x/dav1d
1
0
Fork 0
mirror of https://code.videolan.org/videolan/dav1d synced 2026-06-11 04:03:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Mark C globals with small code model

Browse Source 
We have new option in clang (https://github.com/llvm/llvm-project/pull/124834)
to mark globals to be allocated in non-large sections. We can mark all globals
that are referenced from hardcoded assembly (which implicitly references globals
assuming they are in non-large sections) with this attribute to avoid running
into problems when dav1d is built with -mcmodel=medium with clang.
This commit is contained in:
Pranav Kant
2025-02-21 15:55:00 +00:00
committed by Henrik Gramner
co-authored by Henrik Gramner
parent 42b2b24fb8
commit 7d4b789f55
2 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
include/common/attributes.h
+6
View File
@@ -123,6 +123,12 @@
#define EXTERN extern
#endif
#if ARCH_X86_64 && __has_attribute(model)
#define ATTR_MCMODEL_SMALL __attribute__((model("small")))
#else
#define ATTR_MCMODEL_SMALL
#endif
#ifdef __clang__
#define NO_SANITIZE(x) __attribute__((no_sanitize(x)))
#else
src/tables.c
+7
View File
@@ -419,6 +419,7 @@ const uint16_t ALIGN(dav1d_sgr_params[16][2], 4) = {
{ 0, 1177 }, { 0, 925 }, { 56, 0 }, { 22, 0 },
};
ATTR_MCMODEL_SMALL
const uint8_t ALIGN(dav1d_sgr_x_by_x[256], 64) = {
255, 128, 85, 64, 51, 43, 37, 32, 28, 26, 23, 21, 20, 18, 17,
16, 15, 14, 13, 13, 12, 12, 11, 11, 10, 10, 9, 9, 9, 9,
@@ -440,6 +441,7 @@ const uint8_t ALIGN(dav1d_sgr_x_by_x[256], 64) = {
0
};
ATTR_MCMODEL_SMALL
const int8_t ALIGN(dav1d_mc_subpel_filters[6][15][8], 8) = {
[DAV1D_FILTER_8TAP_REGULAR] = {
{ 0, 1, -3, 63, 4, -1, 0, 0 },
@@ -544,6 +546,7 @@ const int8_t ALIGN(dav1d_mc_subpel_filters[6][15][8], 8) = {
}
};
ATTR_MCMODEL_SMALL
const int8_t ALIGN(dav1d_mc_warp_filter[193][8], 8) = {
// [-1, 0)
{ 0, 0, 127, 1, 0, 0, 0, 0 }, { 0, -1, 127, 2, 0, 0, 0, 0 },
@@ -648,6 +651,7 @@ const int8_t ALIGN(dav1d_mc_warp_filter[193][8], 8) = {
{ 0, 0, 0, 0, 2, 127, -1, 0 },
};
ATTR_MCMODEL_SMALL
const int8_t ALIGN(dav1d_resize_filter[64][8], 8) = {
{ 0, 0, 0, -128, 0, 0, 0, 0 }, { 0, 0, 1, -128, -2, 1, 0, 0 },
{ 0, -1, 3, -127, -4, 2, -1, 0 }, { 0, -1, 4, -127, -6, 3, -1, 0 },
@@ -711,6 +715,7 @@ const uint8_t ALIGN(dav1d_sm_weights[128], 16) = {
7, 6, 6, 5, 5, 4, 4, 4
};
ATTR_MCMODEL_SMALL
const uint16_t dav1d_dr_intra_derivative[44] = {
// Values that are 0 will never be used
0, // Angles:
@@ -756,6 +761,7 @@ const uint16_t dav1d_dr_intra_derivative[44] = {
[1*idx+32] = f4, [1*idx+40] = f5, \
[1*idx+48] = f6
#endif
ATTR_MCMODEL_SMALL
const int8_t ALIGN(dav1d_filter_intra_taps[5][64], 64) = {
{
F( 0, -6, 10, 0, 0, 0, 12, 0 ),
@@ -822,6 +828,7 @@ const uint8_t ALIGN(dav1d_obmc_masks[64], 16) = {
};
// Taken from the spec. Range is [-2048, 2047], mean is 0 and stddev is 512
ATTR_MCMODEL_SMALL
const int16_t dav1d_gaussian_sequence[2048] = {
56, 568, -180, 172, 124, -84, 172, -64, -900, 24, 820,
224, 1248, 996, 272, -8, -916, -388, -732, -104, -188, 800,